Skip to content

Add HIP to the memory profiler device list #38795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Add HIP to the memory profiler device list #38795

wants to merge 3 commits into from

Conversation

@ilia-cher
Copy link
Contributor

@ilia-cher ilia-cher commented May 20, 2020 •
edited
Loading

Stack from ghstack:

Summary:
Add HIP alongside CUDA

Test Plan:
rocm CI

Differential Revision: D21665627

Add HIP to the memory profiler device list
0174a2f 
Summary:
Add HIP alongside CUDA

Test Plan:
rocm CI

Reviewers:

Subscribers:

Tasks:

Tags:

[ghstack-poisoned]
@ilia-cher ilia-cher requested review from albanD and apaszke as code owners May 20, 2020 17:41
ilia-cher pushed a commit that referenced this pull request May 20, 2020
Add HIP to the memory profiler device list
8a6b818 
Summary:
Add HIP alongside CUDA

Test Plan:
rocm CI

Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: 1ccfbb3
Pull Request resolved: #38795
@ilia-cher ilia-cher requested a review from ngimel May 20, 2020 17:44
ngimel
ngimel approved these changes May 20, 2020
View reviewed changes
Copy link
Collaborator

@ngimel ngimel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's wait for CI

@ilia-cher ilia-cher mentioned this pull request May 20, 2020
Closed
@dr-ci
Copy link

dr-ci bot commented May 20, 2020 •
edited
Loading

💊 CI failures summary and remediations

As of commit e79700f (more details on the Dr. CI page):

  • 1/1 failures possibly* introduced in this PR
    • 1/1 non-CircleCI failure(s)

ci.pytorch.org: 1 failed

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 8 times.

@ilia-cher ilia-cher mentioned this pull request May 20, 2020
Closed
@jeffdaily
Copy link
Collaborator

Beat me to it. I was just about to push the same PR. I tested this PR locally and it passed.

BTW ROCm CI might be failing now due to an unrelated change that landed while this memory profiler failure was blocking ROCm CI.

@ilia-cher
Copy link
Contributor Author

ilia-cher commented May 20, 2020 •
edited
Loading

I remember rocm build was not passing before my PR landed

@ilia-cher ilia-cher mentioned this pull request May 20, 2020
Closed
ilia-cher added 2 commits May 20, 2020 13:32
Update on "Add HIP to the memory profiler device list"
7461432 
Summary:
Add HIP alongside CUDA

Test Plan:
rocm CI

Differential Revision: [D21665627](https://our.internmc.facebook.com/intern/diff/D21665627)

[ghstack-poisoned]
Update on "Add HIP to the memory profiler device list"
e79700f 
Summary:
Add HIP alongside CUDA

Test Plan:
rocm CI

Differential Revision: [D21665627](https://our.internmc.facebook.com/intern/diff/D21665627)

[ghstack-poisoned]
@ilia-cher
Copy link
Contributor Author

"test_memory_profiler (main.TestAutograd) ... ok"
in
https://ci.pytorch.org/jenkins/job/pytorch-builds/job/py3.6-clang7-rocmdeb-ubuntu16.04-test2/28720/consoleFull

@ilia-cher
Copy link
Contributor Author

and bloat16 tests are broken on the trunk
https://ci.pytorch.org/jenkins/job/pytorch-builds/job/py3.6-clang7-rocmdeb-ubuntu16.04-test2/28725//console

@ilia-cher
Copy link
Contributor Author

https://ezyang.github.io/pytorch-ci-hud/build/pytorch-master

@facebook-github-bot
Copy link
Contributor

@ilia-cher merged this pull request in 83fa3f1.

@jeffdaily
Copy link
Collaborator

bfloat16 tests should be fixed by this #38823, we were just waiting for it to merge.

We are aware of the build dashboard, and check it if not once but many times a day, due to upstream commits frequently landing without ROCm CI passing.

We need help from the community and the maintainers to make ROCm CI more stable, e.g. not landing PRs with known breakage for ROCm back-end. Meanwhile, we are trying our best to improve the CI maintenance process and our software quality.

@facebook-github-bot facebook-github-bot deleted the gh/ilia-cher/70/head branch May 24, 2020 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ngimel ngimel ngimel approved these changes

@albanD albanD Awaiting requested review from albanD

@apaszke apaszke Awaiting requested review from apaszke

Assignees

No one assigned

Labels

Merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@ilia-cher @jeffdaily @facebook-github-bot @ngimel @mruberry